Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01926202 authored by Shawn Lin's avatar Shawn Lin Committed by Kalle Valo
Browse files

mwifiex: simplify the code around ra_list 



We don't need to check if the list is empty separately
as we could use list_first_entry_or_null to cover it.

Signed-off-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 4f8e2545

drivers/net/wireless/marvell/mwifiex/tdls.c

+2 −5
Original line number Diff line number Diff line
@@ -55,11 +55,8 @@ static void mwifiex_restore_tdls_packets(struct mwifiex_private *priv, 
			tx_info->flags |= MWIFIEX_BUF_FLAG_TDLS_PKT;

		} else {

			tid_list = &priv->wmm.tid_tbl_ptr[tid_down].ra_list;

			if (!list_empty(tid_list))

				ra_list = list_first_entry(tid_list,

			ra_list = list_first_entry_or_null(tid_list,

					struct mwifiex_ra_list_tbl, list);

			else

				ra_list = NULL;

			tx_info->flags &= ~MWIFIEX_BUF_FLAG_TDLS_PKT;

		}

drivers/net/wireless/marvell/mwifiex/wmm.c

+2 −6
Original line number Diff line number Diff line
@@ -868,12 +868,8 @@ mwifiex_wmm_add_buf_txqueue(struct mwifiex_private *priv, 
			return;

		default:

			list_head = priv->wmm.tid_tbl_ptr[tid_down].ra_list;

			if (!list_empty(&list_head))

				ra_list = list_first_entry(

					&list_head, struct mwifiex_ra_list_tbl,

					list);

			else

				ra_list = NULL;

			ra_list = list_first_entry_or_null(&list_head,

					struct mwifiex_ra_list_tbl, list);

			break;

		}

	} else {