Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0171dc6a authored by Álvaro Fernández Rojas's avatar Álvaro Fernández Rojas Committed by Jacek Anaszewski
Browse files

leds: bcm6328: remove unneded lock when checking initial LED 



This lock isn't really needed, since we're only reading the register and
changes made to other LEDs aren't relevant.

Signed-off-by: default avatarÁlvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
parent 41251e24

drivers/leds/leds-bcm6328.c

+0 −3
Original line number Original line Diff line number Diff line
@@ -264,7 +264,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, 
		       unsigned long *blink_leds, unsigned long *blink_delay)

		       unsigned long *blink_leds, unsigned long *blink_delay)

{

{

	struct bcm6328_led *led;

	struct bcm6328_led *led;

	unsigned long flags;

	const char *state;

	const char *state;

	int rc;

	int rc;
@@ -286,7 +285,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, 
						    "linux,default-trigger",

						    "linux,default-trigger",

						    NULL);

						    NULL);





	spin_lock_irqsave(lock, flags);

	if (!of_property_read_string(nc, "default-state", &state)) {

	if (!of_property_read_string(nc, "default-state", &state)) {

		if (!strcmp(state, "on")) {

		if (!strcmp(state, "on")) {

			led->cdev.brightness = LED_FULL;

			led->cdev.brightness = LED_FULL;
@@ -314,7 +312,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, 
	} else {

	} else {

		led->cdev.brightness = LED_OFF;

		led->cdev.brightness = LED_OFF;

	}

	}

	spin_unlock_irqrestore(lock, flags);





	bcm6328_led_set(&led->cdev, led->cdev.brightness);

	bcm6328_led_set(&led->cdev, led->cdev.brightness);