Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01719c2e authored by Razmik Karapetyan's avatar Razmik Karapetyan Committed by Felipe Balbi
Browse files

usb: dwc2: Remove unnecessary request length checking 



Remove request length checking from dwc2_hsotg_unmap_dma() and
dwc2_hsotg_map_dma(). That checking is done in functions called from
those functions, usb_gadget_unmap_request_by_dev() and
usb_gadget_map_request_by_dev() respectively, so it's unnecessary.

Signed-off-by: default avatarRazmik Karapetyan <razmik@synopsys.com>
Signed-off-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent c3b22fe2

drivers/usb/dwc2/gadget.c

+0 −10
Original line number Diff line number Diff line
@@ -316,11 +316,6 @@ static void dwc2_hsotg_unmap_dma(struct dwc2_hsotg *hsotg, 
				struct dwc2_hsotg_req *hs_req)

{

	struct usb_request *req = &hs_req->req;



	/* ignore this if we're not moving any data */

	if (hs_req->req.length == 0)

		return;



	usb_gadget_unmap_request(&hsotg->gadget, req, hs_ep->dir_in);

}
@@ -1101,13 +1096,8 @@ static int dwc2_hsotg_map_dma(struct dwc2_hsotg *hsotg, 
			     struct dwc2_hsotg_ep *hs_ep,

			     struct usb_request *req)

{

	struct dwc2_hsotg_req *hs_req = our_req(req);

	int ret;



	/* if the length is zero, ignore the DMA data */

	if (hs_req->req.length == 0)

		return 0;



	ret = usb_gadget_map_request(&hsotg->gadget, req, hs_ep->dir_in);

	if (ret)

		goto dma_error;