Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 006e84ee authored by Catalin Marinas's avatar Catalin Marinas Committed by Andi Kleen
Browse files

[PATCH] x86-64: do not always end the stack trace with ULONG_MAX 



It makes more sense to end the stack trace with ULONG_MAX only if
nr_entries < max_entries.  Otherwise, we lose one entry in the long stack
traces and cannot know whether the trace was complete or not.

Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Cc: Jan Beulich <jbeulich@novell.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
parent 5558870b

arch/x86_64/kernel/stacktrace.c

+3 −2
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ static void save_stack_address(void *data, unsigned long addr) 
		trace->skip--;

		return;

	}

	if (trace->nr_entries < trace->max_entries - 1)

	if (trace->nr_entries < trace->max_entries)

		trace->entries[trace->nr_entries++] = addr;

}
@@ -49,6 +49,7 @@ static struct stacktrace_ops save_stack_ops = { 
void save_stack_trace(struct stack_trace *trace, struct task_struct *task)

{

	dump_trace(task, NULL, NULL, &save_stack_ops, trace);

	if (trace->nr_entries < trace->max_entries)

		trace->entries[trace->nr_entries++] = ULONG_MAX;

}

EXPORT_SYMBOL(save_stack_trace);