Commit ffecc05d authored Jan 30, 2021 by DENG Qingfang Committed by Greg Kroah-Hartman Feb 10, 2021

net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add



commit f72f2fb8fb6be095b98af5d740ac50cffd0b0cae upstream.

Having multiple destination ports for a unicast address does not make
sense.
Make port_db_load_purge override existent unicast portvec instead of
adding a new port bit.

Fixes: 88472939 ("net: dsa: mv88e6xxx: handle multiple ports in ATU")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20210130134334.10243-1-dqfext@gmail.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9c7b01fc

drivers/net/dsa/mv88e6xxx/chip.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1658,7 +1658,11 @@ static int mv88e6xxx_port_db_load_purge(struct mv88e6xxx_chip *chip, int port,
		if (!entry.portvec)
		entry.state = MV88E6XXX_G1_ATU_DATA_STATE_UNUSED;
		} else {
		if (state == MV88E6XXX_G1_ATU_DATA_STATE_UC_STATIC)
		entry.portvec = BIT(port);
		else
		entry.portvec \|= BIT(port);

		entry.state = state;
		}