Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffd9995b authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Greg Kroah-Hartman
Browse files

r8169: fix jumbo packet handling on RTL8168e 

[ Upstream commit 6cf739131a15e4177e58a1b4f2bede9d5da78552 ]

Josef reported [0] that using jumbo packets fails on RTL8168e.
Aligning the values for register MaxTxPacketSize with the
vendor driver fixes the problem.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=211827



Fixes: d58d46b5 ("r8169: jumbo fixes.")
Reported-by: default avatarJosef Oškera <joskera@redhat.com>
Tested-by: default avatarJosef Oškera <joskera@redhat.com>
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/b15ddef7-0d50-4320-18f4-6a3f86fbfd3e@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 2d032410

drivers/net/ethernet/realtek/r8169.c

+2 −2
Original line number Diff line number Diff line
@@ -4365,7 +4365,7 @@ static void r8168dp_hw_jumbo_disable(struct rtl8169_private *tp) 


static void r8168e_hw_jumbo_enable(struct rtl8169_private *tp)

{

	RTL_W8(tp, MaxTxPacketSize, 0x3f);

	RTL_W8(tp, MaxTxPacketSize, 0x24);

	RTL_W8(tp, Config3, RTL_R8(tp, Config3) | Jumbo_En0);

	RTL_W8(tp, Config4, RTL_R8(tp, Config4) | 0x01);

	rtl_tx_performance_tweak(tp, PCI_EXP_DEVCTL_READRQ_512B);
@@ -4373,7 +4373,7 @@ static void r8168e_hw_jumbo_enable(struct rtl8169_private *tp) 


static void r8168e_hw_jumbo_disable(struct rtl8169_private *tp)

{

	RTL_W8(tp, MaxTxPacketSize, 0x0c);

	RTL_W8(tp, MaxTxPacketSize, 0x3f);

	RTL_W8(tp, Config3, RTL_R8(tp, Config3) & ~Jumbo_En0);

	RTL_W8(tp, Config4, RTL_R8(tp, Config4) & ~0x01);

	rtl_tx_performance_tweak(tp, PCI_EXP_DEVCTL_READRQ_4096B);