Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffa56e54 authored by Jesper Juhl's avatar Jesper Juhl Committed by John W. Linville
Browse files

mac80211: Remove redundant checks for NULL before calls to crypto_free_cipher() 



crypto_free_cipher() is a wrapper around crypto_free_tfm() which is a
wrapper around crypto_destroy_tfm() and the latter can handle being passed
a NULL pointer, so checking for NULL in the
ieee80211_aes_key_free()/ieee80211_aes_cmac_key_free() wrappers around
crypto_free_cipher() is pointless and just increase object code size
needlesly and makes us execute extra test/branch instructions that we
don't need.
Btw; don't we have to many wrappers around wrappers ad nauseam here?
Anyway, this patch removes the redundant conditionals.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 723fc7af

net/mac80211/aes_ccm.c

+1 −2
Original line number Diff line number Diff line
@@ -147,6 +147,5 @@ struct crypto_cipher *ieee80211_aes_key_setup_encrypt(const u8 key[]) 


void ieee80211_aes_key_free(struct crypto_cipher *tfm)

{

	if (tfm)

	crypto_free_cipher(tfm);

}

net/mac80211/aes_cmac.c

+1 −2
Original line number Diff line number Diff line
@@ -128,6 +128,5 @@ struct crypto_cipher * ieee80211_aes_cmac_key_setup(const u8 key[]) 


void ieee80211_aes_cmac_key_free(struct crypto_cipher *tfm)

{

	if (tfm)

	crypto_free_cipher(tfm);

}