Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff862a46 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

af_key: more info leaks in pfkey messages 



This is inspired by a5cc68f3 "af_key: fix info leaks in notify
messages".  There are some struct members which don't get initialized
and could disclose small amounts of private information.

Acked-by: default avatarMathias Krause <minipli@googlemail.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a264b981

net/key/af_key.c

+4 −0
Original line number Diff line number Diff line
@@ -2081,6 +2081,7 @@ static int pfkey_xfrm_policy2msg(struct sk_buff *skb, const struct xfrm_policy * 
			pol->sadb_x_policy_type = IPSEC_POLICY_NONE;

	}

	pol->sadb_x_policy_dir = dir+1;

	pol->sadb_x_policy_reserved = 0;

	pol->sadb_x_policy_id = xp->index;

	pol->sadb_x_policy_priority = xp->priority;
@@ -3137,7 +3138,9 @@ static int pfkey_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *t, struct 
	pol->sadb_x_policy_exttype = SADB_X_EXT_POLICY;

	pol->sadb_x_policy_type = IPSEC_POLICY_IPSEC;

	pol->sadb_x_policy_dir = XFRM_POLICY_OUT + 1;

	pol->sadb_x_policy_reserved = 0;

	pol->sadb_x_policy_id = xp->index;

	pol->sadb_x_policy_priority = xp->priority;



	/* Set sadb_comb's. */

	if (x->id.proto == IPPROTO_AH)
@@ -3525,6 +3528,7 @@ static int pfkey_send_migrate(const struct xfrm_selector *sel, u8 dir, u8 type, 
	pol->sadb_x_policy_exttype = SADB_X_EXT_POLICY;

	pol->sadb_x_policy_type = IPSEC_POLICY_IPSEC;

	pol->sadb_x_policy_dir = dir + 1;

	pol->sadb_x_policy_reserved = 0;

	pol->sadb_x_policy_id = 0;

	pol->sadb_x_policy_priority = 0;