Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff595a33 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

slimbus: qcom: Fix return value check in qcom_slim_probe() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f8d2c8ea

drivers/slimbus/qcom-ctrl.c

+2 −2
Original line number Diff line number Diff line
@@ -529,9 +529,9 @@ static int qcom_slim_probe(struct platform_device *pdev) 


	slim_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ctrl");

	ctrl->base = devm_ioremap_resource(ctrl->dev, slim_mem);

	if (!ctrl->base) {

	if (IS_ERR(ctrl->base)) {

		dev_err(&pdev->dev, "IOremap failed\n");

		return -ENOMEM;

		return PTR_ERR(ctrl->base);

	}



	sctrl->set_laddr = qcom_set_laddr;