Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff13b39e authored by Keith Busch's avatar Keith Busch Committed by Christoph Hellwig
Browse files

nvme/pci: Delete misleading queue-wrap comment 



It is not theoretically possible for this driver to wrap twice while
processing completions. The driver allocates only 'queue_depth - 1'
tags, so there can never be more than that to reap when processing a
completion queue. Removing this misleading comment makes it a little
less likely people with broken controllers will blame the driver for
their spurious interrupts.

Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 9fa196e7

drivers/nvme/host/pci.c

+0 −7
Original line number Diff line number Diff line
@@ -712,15 +712,8 @@ static void __nvme_process_cq(struct nvme_queue *nvmeq, unsigned int *tag) 
		req = blk_mq_tag_to_rq(*nvmeq->tags, cqe.command_id);

		nvme_req(req)->result = cqe.result;

		blk_mq_complete_request(req, le16_to_cpu(cqe.status) >> 1);



	}



	/* If the controller ignores the cq head doorbell and continuously

	 * writes to the queue, it is theoretically possible to wrap around

	 * the queue twice and mistakenly return IRQ_NONE.  Linux only

	 * requires that 0.1% of your interrupts are handled, so this isn't

	 * a big problem.

	 */

	if (head == nvmeq->cq_head && phase == nvmeq->cq_phase)

		return;