Commit feda79bf authored Jul 01, 2010 by Julia Lawall Committed by Mauro Carvalho Chehab Aug 02, 2010

V4L/DVB: drivers/media/video/gspca: Use kmemdup

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 230b27cd

drivers/media/video/gspca/t613.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -572,12 +572,11 @@ static void reg_w_buf(struct gspca_dev *gspca_dev,
	} else {		} else {
	u8 *tmpbuf;		u8 *tmpbuf;

	tmpbuf = kmalloc(len, GFP_KERNEL);		tmpbuf = kmemdup(buffer, len, GFP_KERNEL);
	if (!tmpbuf) {		if (!tmpbuf) {
	err("Out of memory");		err("Out of memory");
	return;		return;
	}		}
	memcpy(tmpbuf, buffer, len);
	usb_control_msg(gspca_dev->dev,		usb_control_msg(gspca_dev->dev,
	usb_sndctrlpipe(gspca_dev->dev, 0),		usb_sndctrlpipe(gspca_dev->dev, 0),
	0,		0,