Commit fe46630c authored Oct 05, 2018 by Sergey Matyukevich Committed by Greg Kroah-Hartman Nov 24, 2019

qtnfmac: drop error reports for out-of-bounds key indexes



[ Upstream commit 35da3fe63b8647ce3cc52fccdf186a60710815fb ]

On disconnect wireless core attempts to remove all the supported keys.
Following cfg80211_ops conventions, firmware returns -ENOENT code
for the out-of-bound key indexes. This is a normal behavior,
so no need to report errors for this case.

Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4ecc631d

drivers/net/wireless/quantenna/qtnfmac/cfg80211.c

+10 −3

Original line number	Diff line number	Diff line
		@@ -521,9 +521,16 @@ static int qtnf_del_key(struct wiphy wiphy, struct net_device dev,
		int ret;

		ret = qtnf_cmd_send_del_key(vif, key_index, pairwise, mac_addr);
		if (ret)
		if (ret) {
		if (ret == -ENOENT) {
		pr_debug("VIF%u.%u: key index %d out of bounds\n",
		vif->mac->macid, vif->vifid, key_index);
		} else {
		pr_err("VIF%u.%u: failed to delete key: idx=%u pw=%u\n",
		vif->mac->macid, vif->vifid, key_index, pairwise);
		vif->mac->macid, vif->vifid,
		key_index, pairwise);
		}
		}

		return ret;
		}