Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe0e4052 authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by David S. Miller
Browse files

mdio_bus: use devm_gpiod_get_optional() 



The MDIO reset GPIO is really a classical optional GPIO property case,
so devm_gpiod_get_optional() should have been used, not devm_gpiod_get().
Doing this  saves several LoCs...

Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d396e84c

drivers/net/phy/mdio_bus.c

+5 −9
Original line number Diff line number Diff line
@@ -354,16 +354,12 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner) 
	mutex_init(&bus->mdio_lock);



	/* de-assert bus level PHY GPIO reset */

	gpiod = devm_gpiod_get(&bus->dev, "reset", GPIOD_OUT_LOW);

	gpiod = devm_gpiod_get_optional(&bus->dev, "reset", GPIOD_OUT_LOW);

	if (IS_ERR(gpiod)) {

		err = PTR_ERR(gpiod);

		if (err != -ENOENT) {

			dev_err(&bus->dev,

				"mii_bus %s couldn't get reset GPIO\n",

		dev_err(&bus->dev, "mii_bus %s couldn't get reset GPIO\n",

			bus->id);

			return err;

		}

	} else	{

		return PTR_ERR(gpiod);

	} else	if (gpiod) {

		bus->reset_gpiod = gpiod;



		gpiod_set_value_cansleep(gpiod, 1);