Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe079a5e authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds
Browse files

proc: do mmput ASAP for /proc/*/map_files 

mm_struct is not needed while printing as all the data was already
extracted.

Link: http://lkml.kernel.org/r/20180309223120.GC3843@avx2


Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 58c501aa

fs/proc/base.c

+1 −1
Original line number Diff line number Diff line
@@ -2211,6 +2211,7 @@ proc_map_files_readdir(struct file *file, struct dir_context *ctx) 
		}

	}

	up_read(&mm->mmap_sem);

	mmput(mm);



	for (i = 0; i < nr_files; i++) {

		char buf[4 * sizeof(long) + 2];	/* max: %lx-%lx\0 */
@@ -2228,7 +2229,6 @@ proc_map_files_readdir(struct file *file, struct dir_context *ctx) 
	}

	if (fa)

		flex_array_free(fa);

	mmput(mm);



out_put_task:

	put_task_struct(task);