Commit fdb9cf0b authored Dec 07, 2022 by Jan Kara Committed by Greg Kroah-Hartman Jan 18, 2023

ext4: avoid unaccounted block allocation when expanding inode



commit 8994d11395f8165b3deca1971946f549f0822630 upstream.

When expanding inode space in ext4_expand_extra_isize_ea() we may need
to allocate external xattr block. If quota is not initialized for the
inode, the block allocation will not be accounted into quota usage. Make
sure the quota is initialized before we try to expand inode space.

Reported-by: Pengfei Xu <pengfei.xu@intel.com>
Link: https://lore.kernel.org/all/Y5BT+k6xWqthZc1P@xpf.sh.intel.com


Signed-off-by: Jan Kara <jack@suse.cz>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20221207115937.26601-2-jack@suse.cz


Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a02a0a4b

fs/ext4/inode.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -6041,6 +6041,14 @@ static int __ext4_expand_extra_isize(struct inode *inode,
		return 0;
		}

		/*
		* We may need to allocate external xattr block so we need quotas
		* initialized. Here we can be called with various locks held so we
		* cannot affort to initialize quotas ourselves. So just bail.
		*/
		if (dquot_initialize_needed(inode))
		return -EAGAIN;

		/* try to expand with EAs present */
		error = ext4_expand_extra_isize_ea(inode, new_extra_isize,
		raw_inode, handle);