Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd6dcb88 authored by Helmut Schaa's avatar Helmut Schaa Committed by John W. Linville
Browse files

rt2x00: don't use TXDONE_FALLBACK as success indicator 



TXDONE_FALLBACK doesn't express if the frame was sent successful or not. It
only tells us that the hw used fallback rates for retries. Hence, don't use
TXDONE_FALLBACK as success indicator.

Before this patch we reported success to the rate control algorithm which
was wrong in a number of cases and might have lead to improper tx rate
selections.

Signed-off-by: default avatarHelmut Schaa <helmut.schaa@googlemail.com>
Acked-by: default avatarGertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 46678b19

drivers/net/wireless/rt2x00/rt2x00dev.c

+1 −2
Original line number Diff line number Diff line
@@ -236,8 +236,7 @@ void rt2x00lib_txdone(struct queue_entry *entry, 
	 */

	success =

	    test_bit(TXDONE_SUCCESS, &txdesc->flags) ||

	    test_bit(TXDONE_UNKNOWN, &txdesc->flags) ||

	    test_bit(TXDONE_FALLBACK, &txdesc->flags);

	    test_bit(TXDONE_UNKNOWN, &txdesc->flags);



	/*

	 * Update TX statistics.