Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd24c4af authored by David S. Miller's avatar David S. Miller
Browse files

sunhme: Remove stop/wake TX queue calls in set-multicast-list handler. 



Based upon a bug report by Alexander Beregalov and commentary
from Ben Hutchings.

These are totally unnecessary, in particular because this
driver's ->hard_start_xmit() handler takes the same driver
spinlock that the set-multicast-list handler uses.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebbdbd7c

drivers/net/sunhme.c

+0 −4
Original line number Original line Diff line number Diff line
@@ -2377,8 +2377,6 @@ static void happy_meal_set_multicast(struct net_device *dev) 




	spin_lock_irq(&hp->happy_lock);

	spin_lock_irq(&hp->happy_lock);





	netif_stop_queue(dev);



	if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) {

	if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) {

		hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff);

		hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff);

		hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff);

		hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff);
@@ -2410,8 +2408,6 @@ static void happy_meal_set_multicast(struct net_device *dev) 
		hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]);

		hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]);

	}

	}





	netif_wake_queue(dev);



	spin_unlock_irq(&hp->happy_lock);

	spin_unlock_irq(&hp->happy_lock);

}

}