Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd13c144 authored by Stefan Wahren's avatar Stefan Wahren Committed by Thierry Reding
Browse files

pwm: bcm2835: Prevent division by zero 



It's possible that the PWM clock becomes an orphan. So better check the
result of clk_get_rate() in order to prevent a division by zero.

Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent ebe88b6a

drivers/pwm/pwm-bcm2835.c

+9 −1
Original line number Diff line number Diff line
@@ -65,7 +65,15 @@ static int bcm2835_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, 
			      int duty_ns, int period_ns)

{

	struct bcm2835_pwm *pc = to_bcm2835_pwm(chip);

	unsigned long scaler = NSEC_PER_SEC / clk_get_rate(pc->clk);

	unsigned long rate = clk_get_rate(pc->clk);

	unsigned long scaler;



	if (!rate) {

		dev_err(pc->dev, "failed to get clock rate\n");

		return -EINVAL;

	}



	scaler = NSEC_PER_SEC / rate;



	if (period_ns <= MIN_PERIOD) {

		dev_err(pc->dev, "period %d not supported, minimum %d\n",