Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc4e98db authored by Alexander Aring's avatar Alexander Aring Committed by David S. Miller
Browse files

6lowpan: use stack buffer instead of heap 



head buffer is only temporary available in lowpan_header_create.
So it's not necessary to put it on the heap.

Also fixed a comment codestyle issue.

Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a07fdcec

net/ieee802154/6lowpan.c

+4 −9
Original line number Diff line number Diff line
@@ -377,17 +377,14 @@ static int lowpan_header_create(struct sk_buff *skb, 
	struct ipv6hdr *hdr;

	const u8 *saddr = _saddr;

	const u8 *daddr = _daddr;

	u8 *head;

	u8 head[100];

	struct ieee802154_addr sa, da;



	if (type != ETH_P_IPV6)

		return 0;

	/* TODO:

	 * if this package isn't ipv6 one, where should it be routed?

	 */

	head = kzalloc(100, GFP_KERNEL);

	if (head == NULL)

		return -ENOMEM;

	if (type != ETH_P_IPV6)

		return 0;



	hdr = ipv6_hdr(skb);

	hc06_ptr = head + 2;
@@ -561,8 +558,6 @@ static int lowpan_header_create(struct sk_buff *skb, 
	skb_pull(skb, sizeof(struct ipv6hdr));

	memcpy(skb_push(skb, hc06_ptr - head), head, hc06_ptr - head);



	kfree(head);



	lowpan_raw_dump_table(__func__, "raw skb data dump", skb->data,

				skb->len);