Commit fc396e06 authored Dec 03, 2017 by Christoffer Dall

KVM: arm/arm64: Fix broken GICH_ELRSR big endian conversion



We are incorrectly rearranging 32-bit words inside a 64-bit typed value
for big endian systems, which would result in never marking a virtual
interrupt as inactive on big endian systems (assuming 32 or fewer LRs on
the hardware).  Fix this by not doing any word order manipulation for
the typed values.

Cc: <stable@vger.kernel.org>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>

parent 6b2ad81b

virt/kvm/arm/hyp/vgic-v2-sr.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -34,11 +34,7 @@ static void __hyp_text save_elrsr(struct kvm_vcpu vcpu, void __iomem base)
		else
		elrsr1 = 0;

		#ifdef CONFIG_CPU_BIG_ENDIAN
		cpu_if->vgic_elrsr = ((u64)elrsr0 << 32) \| elrsr1;
		#else
		cpu_if->vgic_elrsr = ((u64)elrsr1 << 32) \| elrsr0;
		#endif
		}

		static void __hyp_text save_lrs(struct kvm_vcpu vcpu, void __iomem base)