Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbf85e2a authored by Michal Malý's avatar Michal Malý Committed by Jiri Kosina
Browse files

HID: hid-lg4ff: Replace DEVICE_ATTR_RW with DEVICE_ATTR to have all internal... 


HID: hid-lg4ff: Replace DEVICE_ATTR_RW with DEVICE_ATTR to have all internal functions prefixed with "lg4ff_"

Replace DEVICE_ATTR_RW with DEVICE_ATTR to have all internal functions prefixed
with "lg4ff_". All internal functions should be prefixed with just "lg4ff_".
Usage of DEVICE_ATTR_RW breaks this scheme because it expects the functions'
names to match the name of the respective sysfs entry.
This partially reverts "2f1cec32"

Signed-off-by: default avatarMichal Malý <madcatxster@devoid-pointer.net>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent d0afd848

drivers/hid/hid-lg4ff.c

+6 −6
Original line number Diff line number Diff line
@@ -721,8 +721,8 @@ static ssize_t lg4ff_alternate_modes_store(struct device *dev, struct device_att 
}

static DEVICE_ATTR(alternate_modes, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, lg4ff_alternate_modes_show, lg4ff_alternate_modes_store);



/* Read current range and display it in terminal */

static ssize_t range_show(struct device *dev, struct device_attribute *attr,

/* Export the currently set range of the wheel */

static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *attr,

				char *buf)

{

	struct hid_device *hid = to_hid_device(dev);
@@ -748,7 +748,7 @@ static ssize_t range_show(struct device *dev, struct device_attribute *attr, 


/* Set range to user specified value, call appropriate function

 * according to the type of the wheel */

static ssize_t range_store(struct device *dev, struct device_attribute *attr,

static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *attr,

				 const char *buf, size_t count)

{

	struct hid_device *hid = to_hid_device(dev);
@@ -780,7 +780,7 @@ static ssize_t range_store(struct device *dev, struct device_attribute *attr, 


	return count;

}

static DEVICE_ATTR_RW(range);

static DEVICE_ATTR(range, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH, lg4ff_range_show, lg4ff_range_store);



static ssize_t lg4ff_real_id_show(struct device *dev, struct device_attribute *attr, char *buf)

{