Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbf4b934 authored by Richard Cochran's avatar Richard Cochran Committed by David S. Miller
Browse files

dp83640: trivial fixes 



This patch cleans up the input checking code on the external time stamp
function by using an unsigned rather than a signed channel index.

Also, this patch corrects the author's email address. When this macro
was last changed, the top level domain part of the email address was
left behind.

Signed-off-by: default avatarRichard Cochran <richardcochran@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4986b4f0

drivers/net/phy/dp83640.c

+3 −3
Original line number Diff line number Diff line
@@ -424,13 +424,13 @@ static int ptp_dp83640_enable(struct ptp_clock_info *ptp, 
	struct dp83640_clock *clock =

		container_of(ptp, struct dp83640_clock, caps);

	struct phy_device *phydev = clock->chosen->phydev;

	int index;

	unsigned int index;

	u16 evnt, event_num, gpio_num;



	switch (rq->type) {

	case PTP_CLK_REQ_EXTTS:

		index = rq->extts.index;

		if (index < 0 || index >= N_EXT_TS)

		if (index >= N_EXT_TS)

			return -EINVAL;

		event_num = EXT_EVENT + index;

		evnt = EVNT_WR | (event_num & EVNT_SEL_MASK) << EVNT_SEL_SHIFT;
@@ -1363,7 +1363,7 @@ static void __exit dp83640_exit(void) 
}



MODULE_DESCRIPTION("National Semiconductor DP83640 PHY driver");

MODULE_AUTHOR("Richard Cochran <richardcochran@gmail.at>");

MODULE_AUTHOR("Richard Cochran <richardcochran@gmail.com>");

MODULE_LICENSE("GPL");



module_init(dp83640_init);