Commit fb3809dd authored Sep 25, 2019 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 27, 2020

net: netsec: Fix signedness bug in netsec_probe()



[ Upstream commit bd55f8ddbc437c225391ca8f487e7ec10243c4cc ]

The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as an unsigned int so the error handling is never
triggered.

Fixes: 533dd11a ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 49ebb268

drivers/net/ethernet/socionext/netsec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1604,7 +1604,7 @@ static int netsec_probe(struct platform_device *pdev)
		NETIF_MSG_LINK \| NETIF_MSG_PROBE;

		priv->phy_interface = device_get_phy_mode(&pdev->dev);
		if (priv->phy_interface < 0) {
		if ((int)priv->phy_interface < 0) {
		dev_err(&pdev->dev, "missing required property 'phy-mode'\n");
		ret = -ENODEV;
		goto free_ndev;