Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb234035 authored by Xin Long's avatar Xin Long Committed by David S. Miller
Browse files

sctp: remove the useless check in sctp_renege_events 



Remove the 'if (chunk)' check in sctp_renege_events for idata process,
as all renege commands are generated in sctp_eat_data and it can't be
NULL.

The same thing we already did for common data in sctp_ulpq_renege.

Fixes: 94014e8d ("sctp: implement renege_events for sctp_stream_interleave")
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 947820b9

net/sctp/stream_interleave.c

+2 −6
Original line number Diff line number Diff line
@@ -954,12 +954,8 @@ static void sctp_renege_events(struct sctp_ulpq *ulpq, struct sctp_chunk *chunk, 
	__u32 freed = 0;

	__u16 needed;



	if (chunk) {

		needed = ntohs(chunk->chunk_hdr->length);

		needed -= sizeof(struct sctp_idata_chunk);

	} else {

		needed = SCTP_DEFAULT_MAXWINDOW;

	}

	needed = ntohs(chunk->chunk_hdr->length) -

		 sizeof(struct sctp_idata_chunk);



	if (skb_queue_empty(&asoc->base.sk->sk_receive_queue)) {

		freed = sctp_ulpq_renege_list(ulpq, &ulpq->lobby, needed);