Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb11c9c6 authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

cpuidle: reduce code duplication inside cpuidle_idle_call() 



We are doing this twice in cpuidle_idle_call() routine:
	drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP

Would be better if we actually store this in a local variable and
use that. That reduces code duplication and likely makes this piece
of code run faster (in case the compiler wasn't able to optimize it
earlier)

[rjw: Cast the result of bitwise AND to bool explicitly using !!]
Acked-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 9b29a86f

drivers/cpuidle/cpuidle.c

+5 −2
Original line number Diff line number Diff line
@@ -118,6 +118,7 @@ int cpuidle_idle_call(void) 
	struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices);

	struct cpuidle_driver *drv;

	int next_state, entered_state;

	bool broadcast;



	if (off || !initialized)

		return -ENODEV;
@@ -141,7 +142,9 @@ int cpuidle_idle_call(void) 


	trace_cpu_idle_rcuidle(next_state, dev->cpu);



	if (drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP)

	broadcast = !!(drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP);



	if (broadcast)

		clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER,

				   &dev->cpu);
@@ -151,7 +154,7 @@ int cpuidle_idle_call(void) 
	else

		entered_state = cpuidle_enter_state(dev, drv, next_state);



	if (drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP)

	if (broadcast)

		clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT,

				   &dev->cpu);