Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fac59136 authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

[media] RedRat3: Return directly after a failed kcalloc() in redrat3_transmit_ir() 



* Return directly after a call of the function "kcalloc" failed
  at the beginning.

* Reorder two calls for the function "kfree" at the end.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 576df632

drivers/media/rc/redrat3.c

+3 −5
Original line number Diff line number Diff line
@@ -777,10 +777,8 @@ static int redrat3_transmit_ir(struct rc_dev *rcdev, unsigned *txbuf, 
	sample_lens = kcalloc(RR3_DRIVER_MAXLENS,

			      sizeof(*sample_lens),

			      GFP_KERNEL);

	if (!sample_lens) {

		ret = -ENOMEM;

		goto out;

	}

	if (!sample_lens)

		return -ENOMEM;



	irdata = kzalloc(sizeof(*irdata), GFP_KERNEL);

	if (!irdata) {
@@ -848,8 +846,8 @@ static int redrat3_transmit_ir(struct rc_dev *rcdev, unsigned *txbuf, 
		ret = count;



out:

	kfree(sample_lens);

	kfree(irdata);

	kfree(sample_lens);



	rr3->transmitting = false;

	/* rr3 re-enables rc detector because it was enabled before */