Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faa3aad7 authored by Serge E. Hallyn's avatar Serge E. Hallyn Committed by James Morris
Browse files

securityfs: fix long-broken securityfs_create_file comment 



If there is an error creating a file through securityfs_create_file,
NULL is not returned, rather the error is propagated.

Signed-off-by: default avatarSerge E. Hallyn <serue@us.ibm.com>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 5626d3e8

security/inode.c

+3 −4
Original line number Diff line number Diff line
@@ -205,12 +205,11 @@ static int create_by_name(const char *name, mode_t mode, 
 * This function returns a pointer to a dentry if it succeeds.  This

 * pointer must be passed to the securityfs_remove() function when the file is

 * to be removed (no automatic cleanup happens if your module is unloaded,

 * you are responsible here).  If an error occurs, %NULL is returned.

 * you are responsible here).  If an error occurs, the function will return

 * the erorr value (via ERR_PTR).

 *

 * If securityfs is not enabled in the kernel, the value %-ENODEV is

 * returned.  It is not wise to check for this value, but rather, check for

 * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling

 * code.

 * returned.

 */

struct dentry *securityfs_create_file(const char *name, mode_t mode,

				   struct dentry *parent, void *data,