Commit fa9a9a08 authored Jul 02, 2015 by Nishanth Aravamudan Committed by Herbert Xu Jul 06, 2015

crypto: nx - nx842_OF_upd_status should return ENODEV if device is not 'okay'

The current documention mentions explicitly that EINVAL should be
returned if the device is not available, but nx842_OF_upd_status()
always returns 0. However, nx842_probe() specifically checks for
non-ENODEV returns from nx842_of_upd() (which in turn calls
nx842_OF_upd_status()) and emits an extra error in that case. It seems
like the proper return code of a disabled device is ENODEV.

Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 6170511a

drivers/crypto/nx/nx-842-pseries.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -556,7 +556,7 @@ static int nx842_OF_set_defaults(struct nx842_devdata *devdata)
		*
		* Returns:
		* 0 - Device is available
		* -EINVAL - Device is not available
		* -ENODEV - Device is not available
		*/
		static int nx842_OF_upd_status(struct nx842_devdata *devdata,
		struct property *prop) {
		@@ -569,6 +569,7 @@ static int nx842_OF_upd_status(struct nx842_devdata *devdata,
		dev_info(devdata->dev, "%s: status '%s' is not 'okay'\n",
		__func__, status);
		devdata->status = UNAVAILABLE;
		ret = -ENODEV;
		}

		return ret;