Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa68be0d authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds
Browse files

ipmi: remove ->write_proc code 



IPMI code theoretically allows ->write_proc users, but nobody uses this thus
far.

Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Acked-by: default avatarCorey Minyard <minyard@acm.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 95c0ba89

drivers/char/ipmi/ipmi_msghandler.c

+4 −5
Original line number Diff line number Diff line
@@ -1941,7 +1941,7 @@ static int stat_file_read_proc(char *page, char **start, off_t off, 
#endif /* CONFIG_PROC_FS */



int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,

			    read_proc_t *read_proc, write_proc_t *write_proc,

			    read_proc_t *read_proc,

			    void *data, struct module *owner)

{

	int                    rv = 0;
@@ -1968,7 +1968,6 @@ int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name, 
	} else {

		file->data = data;

		file->read_proc = read_proc;

		file->write_proc = write_proc;

		file->owner = owner;



		mutex_lock(&smi->proc_entry_lock);
@@ -1997,17 +1996,17 @@ static int add_proc_entries(ipmi_smi_t smi, int num) 


	if (rv == 0)

		rv = ipmi_smi_add_proc_entry(smi, "stats",

					     stat_file_read_proc, NULL,

					     stat_file_read_proc,

					     smi, THIS_MODULE);



	if (rv == 0)

		rv = ipmi_smi_add_proc_entry(smi, "ipmb",

					     ipmb_file_read_proc, NULL,

					     ipmb_file_read_proc,

					     smi, THIS_MODULE);



	if (rv == 0)

		rv = ipmi_smi_add_proc_entry(smi, "version",

					     version_file_read_proc, NULL,

					     version_file_read_proc,

					     smi, THIS_MODULE);

#endif /* CONFIG_PROC_FS */

drivers/char/ipmi/ipmi_si_intf.c

+3 −3
Original line number Diff line number Diff line
@@ -2892,7 +2892,7 @@ static int try_smi_init(struct smi_info *new_smi) 
	}



	rv = ipmi_smi_add_proc_entry(new_smi->intf, "type",

				     type_file_read_proc, NULL,

				     type_file_read_proc,

				     new_smi, THIS_MODULE);

	if (rv) {

		printk(KERN_ERR
@@ -2902,7 +2902,7 @@ static int try_smi_init(struct smi_info *new_smi) 
	}



	rv = ipmi_smi_add_proc_entry(new_smi->intf, "si_stats",

				     stat_file_read_proc, NULL,

				     stat_file_read_proc,

				     new_smi, THIS_MODULE);

	if (rv) {

		printk(KERN_ERR
@@ -2912,7 +2912,7 @@ static int try_smi_init(struct smi_info *new_smi) 
	}



	rv = ipmi_smi_add_proc_entry(new_smi->intf, "params",

				     param_read_proc, NULL,

				     param_read_proc,

				     new_smi, THIS_MODULE);

	if (rv) {

		printk(KERN_ERR

include/linux/ipmi_smi.h

+1 −1
Original line number Diff line number Diff line
@@ -229,7 +229,7 @@ static inline void ipmi_free_smi_msg(struct ipmi_smi_msg *msg) 
   directory for this interface.  Note that the entry will

   automatically be dstroyed when the interface is destroyed. */

int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,

			    read_proc_t *read_proc, write_proc_t *write_proc,

			    read_proc_t *read_proc,

			    void *data, struct module *owner);



#endif /* __LINUX_IPMI_SMI_H */