qtnfmac: fix resource leaks on unsupported iftype error return path (fa0abc3e) · Commits · e / devices / android_kernel_oneplus_sm7250

[ Upstream commit 63f6982075d890d7563e2469643f05a37d193f01 ] Currently if an unsupported iftype is detected the error return path does not free the cmd_skb leading to a resource leak. Fix this by free'ing cmd_skb. Addresses-Coverity: ("Resource leak") Fixes: ("qtnfmac: prepare for AP_VLAN interface type support") Signed-off-by:

Colin Ian King <colin.king@canonical.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200925132224.21638-1-colin.king@canonical.com Signed-off-by:

Sasha Levin <sashal@kernel.org>

drivers/net/wireless/quantenna/qtnfmac/commands.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -894,6 +894,7 @@ int qtnf_cmd_send_del_intf(struct qtnf_vif *vif)
	default:		default:
	pr_warn("VIF%u.%u: unsupported iftype %d\n", vif->mac->macid,		pr_warn("VIF%u.%u: unsupported iftype %d\n", vif->mac->macid,
	vif->vifid, vif->wdev.iftype);		vif->vifid, vif->wdev.iftype);
			dev_kfree_skb(cmd_skb);
	ret = -EINVAL;		ret = -EINVAL;
	goto out;		goto out;
	}		}
	@@ -2212,6 +2213,7 @@ int qtnf_cmd_send_change_sta(struct qtnf_vif vif, const u8 mac,
	break;		break;
	default:		default:
	pr_err("unsupported iftype %d\n", vif->wdev.iftype);		pr_err("unsupported iftype %d\n", vif->wdev.iftype);
			dev_kfree_skb(cmd_skb);
	ret = -EINVAL;		ret = -EINVAL;
	goto out;		goto out;
	}		}