Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9dde187 authored by Jens Axboe's avatar Jens Axboe Committed by Keith Busch
Browse files

nvme-pci: remove cq check after submission 



We always check the completion queue after submitting, but in my testing
this isn't a win even on DRAM/xpoint devices. In some cases it's
actually worse. Kill it.

Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 750dde44

drivers/nvme/host/pci.c

+0 −2
Original line number Diff line number Diff line
@@ -69,7 +69,6 @@ MODULE_PARM_DESC(io_queue_depth, "set io queue depth, should >= 2"); 
struct nvme_dev;

struct nvme_queue;



static void nvme_process_cq(struct nvme_queue *nvmeq);

static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown);



/*
@@ -896,7 +895,6 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx, 
		goto out_cleanup_iod;

	}

	__nvme_submit_cmd(nvmeq, &cmnd);

	nvme_process_cq(nvmeq);

	spin_unlock_irq(&nvmeq->q_lock);

	return BLK_STS_OK;

out_cleanup_iod: