Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9c6442a authored by Ivan Bornyakov's avatar Ivan Bornyakov Committed by David S. Miller
Browse files

atm: zatm: fix memcmp casting 



memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One
can lose significant bits and get 0 from non-0 value returned by the
memcmp().

Signed-off-by: default avatarIvan Bornyakov <brnkv.i1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 31256426

drivers/atm/zatm.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1151,8 +1151,8 @@ static void eprom_get_byte(struct zatm_dev *zatm_dev, unsigned char *byte, 
}

}









static unsigned char eprom_try_esi(struct atm_dev *dev, unsigned short cmd,

static int eprom_try_esi(struct atm_dev *dev, unsigned short cmd, int offset,

				   int offset, int swap)

			 int swap)

{

{

	unsigned char buf[ZEPROM_SIZE];

	unsigned char buf[ZEPROM_SIZE];

	struct zatm_dev *zatm_dev;

	struct zatm_dev *zatm_dev;