Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9859839 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

[media] ov2640: Don't access the device in the g_mbus_fmt operation 



The g_mbus_fmt operation only needs to return the current mbus frame
format and doesn't need to configure the hardware to do so. Fix it to
avoid requiring the chip to be powered on when calling the operation.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2744782e

drivers/media/video/ov2640.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -837,10 +837,8 @@ static int ov2640_g_fmt(struct v4l2_subdev *sd, 




	if (!priv->win) {

	if (!priv->win) {

		u32 width = W_SVGA, height = H_SVGA;

		u32 width = W_SVGA, height = H_SVGA;

		int ret = ov2640_set_params(client, &width, &height,

		priv->win = ov2640_select_win(&width, &height);

					    V4L2_MBUS_FMT_UYVY8_2X8);

		priv->cfmt_code = V4L2_MBUS_FMT_UYVY8_2X8;

		if (ret < 0)

			return ret;

	}

	}





	mf->width	= priv->win->width;

	mf->width	= priv->win->width;