Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f96a6ec1 authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: dwc3: ep0: SetAddress() won't be issued while Configured 



I have talked to USB-IF about USB30CV issuing SetAddres()
with a device on Configured state and they have agreed on
changing USB30CV not to do so.

Adding back the STALL reply in such case and while at
that, also add a debugging message for an address which
is too large.

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent c4da177f

drivers/usb/dwc3/ep0.c

+8 −1
Original line number Diff line number Diff line
@@ -422,8 +422,15 @@ static int dwc3_ep0_set_address(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl) 
	u32 reg;



	addr = le16_to_cpu(ctrl->wValue);

	if (addr > 127)

	if (addr > 127) {

		dev_dbg(dwc->dev, "invalid device address %d\n", addr);

		return -EINVAL;

	}



	if (dwc->dev_state == DWC3_CONFIGURED_STATE) {

		dev_dbg(dwc->dev, "trying to set address when configured\n");

		return -EINVAL;

	}



	reg = dwc3_readl(dwc->regs, DWC3_DCFG);

	reg &= ~(DWC3_DCFG_DEVADDR_MASK);