Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8b11260 authored by Eric Wheeler's avatar Eric Wheeler Committed by Jens Axboe
Browse files

bcache: fix cache_set_flush() NULL pointer dereference on OOM



When bch_cache_set_alloc() fails to kzalloc the cache_set, the
asyncronous closure handling tries to dereference a cache_set that
hadn't yet been allocated inside of cache_set_flush() which is called
by __cache_set_unregister() during cleanup.  This appears to happen only
during an OOM condition on bcache_register.

Signed-off-by: default avatarEric Wheeler <bcache@linux.ewheeler.net>
Cc: stable@vger.kernel.org
parent 9b299728
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -1373,6 +1373,9 @@ static void cache_set_flush(struct closure *cl)
	struct btree *b;
	unsigned i;

	if (!c)
		closure_return(cl);

	bch_cache_accounting_destroy(&c->accounting);

	kobject_put(&c->internal);