Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f862e60f authored by Michael S. Tsirkin's avatar Michael S. Tsirkin
Browse files

drm/virtio: fix lock context imbalance 



When virtio_gpu_free_vbufs exits due to list empty, it does not
drop the free_vbufs lock that it took.
list empty is not expected to happen anyway, but it can't hurt to fix
this and drop the lock.

Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 8854a56f

drivers/gpu/drm/virtio/virtgpu_vq.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -109,8 +109,10 @@ void virtio_gpu_free_vbufs(struct virtio_gpu_device *vgdev) 




	spin_lock(&vgdev->free_vbufs_lock);

	spin_lock(&vgdev->free_vbufs_lock);

	for (i = 0; i < count; i++) {

	for (i = 0; i < count; i++) {

		if (WARN_ON(list_empty(&vgdev->free_vbufs)))

		if (WARN_ON(list_empty(&vgdev->free_vbufs))) {

			spin_unlock(&vgdev->free_vbufs_lock);

			return;

			return;

		}

		vbuf = list_first_entry(&vgdev->free_vbufs,

		vbuf = list_first_entry(&vgdev->free_vbufs,

					struct virtio_gpu_vbuffer, list);

					struct virtio_gpu_vbuffer, list);

		list_del(&vbuf->list);

		list_del(&vbuf->list);