Commit f7ce5d28 authored Jun 17, 2014 by Jeff Layton Committed by J. Bruce Fields Jun 23, 2014

nfsd: fix return of nfs4_acl_write_who



AFAICT, the only way to hit this error is to pass this function a bogus
"who" value. In that case, we probably don't want to return -1 as that
could get sent back to the client. Turn this into nfserr_serverfault,
which is a more appropriate error for a server bug like this.

Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent 94ec938b

fs/nfsd/nfs4acl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -935,5 +935,5 @@ __be32 nfs4_acl_write_who(struct xdr_stream *xdr, int who)
		return 0;
		}
		WARN_ON_ONCE(1);
		return -1;
		return nfserr_serverfault;
		}