Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f786a6d4 authored by Bob Copeland's avatar Bob Copeland Committed by Kalle Valo
Browse files

wcn36xx: use !! when assigning int as a boolean 



bd->tx_comp is a single bit in a bitfield, so assigning
"info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS" only happens
to work because TX_STATUS is defined to BIT(0); if it were
any other bit this assignment would fail.

Signed-off-by: default avatarBob Copeland <me@bobcopeland.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 69a88cc7

drivers/net/wireless/ath/wcn36xx/txrx.c

+1 −1
Original line number Diff line number Diff line
@@ -237,7 +237,7 @@ int wcn36xx_start_tx(struct wcn36xx *wcn, 


	bd->dpu_rf = WCN36XX_BMU_WQ_TX;



	bd->tx_comp = info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS;

	bd->tx_comp = !!(info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS);

	if (bd->tx_comp) {

		wcn36xx_dbg(WCN36XX_DBG_DXE, "TX_ACK status requested\n");

		spin_lock_irqsave(&wcn->dxe_lock, flags);