Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f75c1b29 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

staging: dgnc: delete dgnc_utils.c 



There was just one function in it, and it duplicated what
msleep_interruptable() was doing, which is pointless, so delete it and
fix up the one calling site.

Cc: Lidza Louina <lidza.louina@gmail.com>
Cc: Mark Hounschell <markh@compro.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 78c00ccc

drivers/staging/dgnc/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -2,4 +2,4 @@ obj-$(CONFIG_DGNC) += dgnc.o 


dgnc-objs :=   dgnc_cls.o dgnc_driver.o\

               dgnc_mgmt.o dgnc_neo.o\

               dgnc_tty.o dgnc_utils.o
 
               dgnc_tty.o

drivers/staging/dgnc/dgnc_tty.c

+1 −2
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ 
#include "dgnc_tty.h"

#include "dgnc_neo.h"

#include "dgnc_cls.h"

#include "dgnc_utils.h"



/* Default transparent print information. */
@@ -1229,7 +1228,7 @@ static void dgnc_tty_close(struct tty_struct *tty, struct file *file) 
			if (ch->ch_close_delay) {

				spin_unlock_irqrestore(&ch->ch_lock,

						       flags);

				dgnc_ms_sleep(ch->ch_close_delay);

				msleep_interruptible(ch->ch_close_delay);

				spin_lock_irqsave(&ch->ch_lock, flags);

			}

		}

drivers/staging/dgnc/dgnc_utils.c

deleted100644 → 0
+0 −17
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

#include <linux/tty.h>

#include <linux/sched/signal.h>

#include "dgnc_utils.h"



/**

 * dgnc_ms_sleep - Put the driver to sleep

 * @ms - milliseconds to sleep

 *

 * Return: 0 if timed out, if interrupted by a signal return signal.

 */

int dgnc_ms_sleep(ulong ms)

{

	__set_current_state(TASK_INTERRUPTIBLE);

	schedule_timeout((ms * HZ) / 1000);

	return signal_pending(current);

}

drivers/staging/dgnc/dgnc_utils.h

deleted100644 → 0
+0 −7
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

#ifndef _DGNC_UTILS_H

#define _DGNC_UTILS_H



int dgnc_ms_sleep(ulong ms);



#endif	/* _DGNC_UTILS_H */