Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7488c50 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mauro Carvalho Chehab
Browse files

[media] dm1105: Remove unnecessary synchronize_irq() before free_irq() 



Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
 free_irq(irq, ...);
// </smpl>

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent c1500ba0

drivers/media/pci/dm1105/dm1105.c

+0 −1
Original line number Diff line number Diff line
@@ -1206,7 +1206,6 @@ static void dm1105_remove(struct pci_dev *pdev) 
	i2c_del_adapter(&dev->i2c_adap);



	dm1105_hw_exit(dev);

	synchronize_irq(pdev->irq);

	free_irq(pdev->irq, dev);

	pci_iounmap(pdev, dev->io_mem);

	pci_release_regions(pdev);