Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6bf3a66 authored by Alexander Graf's avatar Alexander Graf
Browse files

KVM: PPC: Book3s HV: Fix tlbie compile error 



Some compilers complain about uninitialized variables in the compute_tlbie_rb
function. When you follow the code path you'll realize that we'll never get
to that point, but the compiler isn't all that smart.

So just default to 4k page sizes for everything, making the compiler happy
and the code slightly easier to read.

Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
Acked-by: default avatarPaul Mackerras <paulus@samba.org>
parent fb4188ba

arch/powerpc/include/asm/kvm_book3s_64.h

+2 −6
Original line number Diff line number Diff line
@@ -110,16 +110,12 @@ static inline int __hpte_actual_psize(unsigned int lp, int psize) 
static inline unsigned long compute_tlbie_rb(unsigned long v, unsigned long r,

					     unsigned long pte_index)

{

	int b_psize, a_psize;

	int b_psize = MMU_PAGE_4K, a_psize = MMU_PAGE_4K;

	unsigned int penc;

	unsigned long rb = 0, va_low, sllp;

	unsigned int lp = (r >> LP_SHIFT) & ((1 << LP_BITS) - 1);



	if (!(v & HPTE_V_LARGE)) {

		/* both base and actual psize is 4k */

		b_psize = MMU_PAGE_4K;

		a_psize = MMU_PAGE_4K;

	} else {

	if (v & HPTE_V_LARGE) {

		for (b_psize = 0; b_psize < MMU_PAGE_COUNT; b_psize++) {



			/* valid entries have a shift value */