Commit f604db64 authored Apr 24, 2018 by Matan Barak Committed by Doug Ledford Apr 27, 2018

IB/uverbs: Fix validating mandatory attributes



Previously, if a method contained mandatory attributes in a namespace
that wasn't given by the user, these attributes weren't validated.
Fixing this by iterating over all specification namespaces.

Fixes: fac9658c ("IB/core: Add new ioctl interface")
Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 26bff1bd

drivers/infiniband/core/uverbs_ioctl.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -234,6 +234,15 @@ static int uverbs_validate_kernel_mandatory(const struct uverbs_method_spec *met
		return -EINVAL;
		}

		for (; i < method_spec->num_buckets; i++) {
		struct uverbs_attr_spec_hash *attr_spec_bucket =
		method_spec->attr_buckets[i];

		if (!bitmap_empty(attr_spec_bucket->mandatory_attrs_bitmask,
		attr_spec_bucket->num_attrs))
		return -EINVAL;
		}

		return 0;
		}