Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit f5958b4c authored by Maciej W. Rozycki's avatar Maciej W. Rozycki Committed by Paul Burton
Browse files

MIPS: Correct the 64-bit DSP accumulator register size 



Use the `unsigned long' rather than `__u32' type for DSP accumulator
registers, like with the regular MIPS multiply/divide accumulator and
general-purpose registers, as all are 64-bit in 64-bit implementations
and using a 32-bit data type leads to contents truncation on context
saving.

Update `arch_ptrace' and `compat_arch_ptrace' accordingly, removing
casts that are similarly not used with multiply/divide accumulator or
general-purpose register accesses.

Signed-off-by: default avatarMaciej W. Rozycki <macro@mips.com>
Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
Fixes: e50c0a8f ("Support the MIPS32 / MIPS64 DSP ASE.")
Patchwork: https://patchwork.linux-mips.org/patch/19329/
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # 2.6.15+
parent 2f819db5

arch/mips/include/asm/processor.h

+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ struct mips_fpu_struct { 


#define NUM_DSP_REGS   6



typedef __u32 dspreg_t;

typedef unsigned long dspreg_t;



struct mips_dsp_state {

	dspreg_t	dspr[NUM_DSP_REGS];

arch/mips/kernel/ptrace.c

+1 −1
Original line number Diff line number Diff line
@@ -856,7 +856,7 @@ long arch_ptrace(struct task_struct *child, long request, 
				goto out;

			}

			dregs = __get_dsp_regs(child);

			tmp = (unsigned long) (dregs[addr - DSP_BASE]);

			tmp = dregs[addr - DSP_BASE];

			break;

		}

		case DSP_CONTROL:

arch/mips/kernel/ptrace32.c

+1 −1
Original line number Diff line number Diff line
@@ -142,7 +142,7 @@ long compat_arch_ptrace(struct task_struct *child, compat_long_t request, 
				goto out;

			}

			dregs = __get_dsp_regs(child);

			tmp = (unsigned long) (dregs[addr - DSP_BASE]);

			tmp = dregs[addr - DSP_BASE];

			break;

		}

		case DSP_CONTROL: