Commit f5908267 authored Dec 23, 2009 by Herbert Xu

hwrng: core - Fix double unlock in rng_dev_read



When the loop terminates with size == 0 in rng_dev_read we will
unlock the rng mutex twice.

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 55639353

drivers/char/hw_random/core.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -158,10 +158,11 @@ static ssize_t rng_dev_read(struct file filp, char __user buf,
		goto out;
		}
		}
		out_unlock:
		mutex_unlock(&rng_mutex);
		out:
		return ret ? : err;
		out_unlock:
		mutex_unlock(&rng_mutex);
		goto out;
		}