Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f57af6df authored by Chunyan Zhang's avatar Chunyan Zhang Committed by Alexander Shishkin
Browse files

stm class: Fix integer boundary checks for master range 



Master IDs are of unsigned int type, yet in the configfs policy code
we're validating user's input against INT_MAX. This is both pointless
and misleading as the real limits are imposed by the stm device's
[sw_start..sw_end] (which are also limited by the spec to be no larger
than 2^16-1).

Clean this up by getting rid of the redundant comparisons.

Signed-off-by: default avatarChunyan Zhang <zhang.chunyan@linaro.org>
Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: default avatarLaurent Fert <laurent.fert@intel.com>
parent e787bc46

drivers/hwtracing/stm/policy.c

+1 −2
Original line number Diff line number Diff line
@@ -107,8 +107,7 @@ stp_policy_node_masters_store(struct config_item *item, const char *page, 
		goto unlock;



	/* must be within [sw_start..sw_end], which is an inclusive range */

	if (first > INT_MAX || last > INT_MAX || first > last ||

	    first < stm->data->sw_start ||

	if (first > last || first < stm->data->sw_start ||

	    last > stm->data->sw_end) {

		ret = -ERANGE;

		goto unlock;