Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5786313 authored by Luis R. Rodriguez's avatar Luis R. Rodriguez Committed by Greg Kroah-Hartman
Browse files

selftests: firmware: only modprobe if driver is missing 



No need to load test_firmware if its already there.
Also use a more generic form to recommend what is required
to be built.

Signed-off-by: default avatarLuis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8a18f428

tools/testing/selftests/firmware/fw_filesystem.sh

+17 −2
Original line number Diff line number Diff line
@@ -5,9 +5,24 @@ 
# know so we can be sure we're not accidentally testing the user helper.

set -e



modprobe test_firmware



DIR=/sys/devices/virtual/misc/test_firmware

TEST_DIR=$(dirname $0)



test_modprobe()

{

	if [ ! -d $DIR ]; then

		echo "$0: $DIR not present"

		echo "You must have the following enabled in your kernel:"

		cat $TEST_DIR/config

		exit 1

	fi

}



trap "test_modprobe" EXIT



if [ ! -d $DIR ]; then

	modprobe test_firmware

fi



# CONFIG_FW_LOADER_USER_HELPER has a sysfs class under /sys/class/firmware/

# These days no one enables CONFIG_FW_LOADER_USER_HELPER so check for that