Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f575a02e authored by Zhu Yanjun's avatar Zhu Yanjun Committed by David S. Miller
Browse files

mlx4_en: remove unnecessary error check 



The function mlx4_en_get_profile always return zero. So it is not
necessary to check its return value.

CC: Joe Jin <joe.jin@oracle.com>
CC: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b5f3e0d4

drivers/net/ethernet/mellanox/mlx4/en_main.c

+2 −7
Original line number Diff line number Diff line
@@ -147,7 +147,7 @@ void mlx4_en_update_loopback_state(struct net_device *dev, 
	mutex_unlock(&priv->mdev->state_lock);

}



static int mlx4_en_get_profile(struct mlx4_en_dev *mdev)

static void mlx4_en_get_profile(struct mlx4_en_dev *mdev)

{

	struct mlx4_en_profile *params = &mdev->profile;

	int i;
@@ -176,8 +176,6 @@ static int mlx4_en_get_profile(struct mlx4_en_dev *mdev) 
		params->prof[i].rss_rings = 0;

		params->prof[i].inline_thold = inline_thold;

	}



	return 0;

}



static void *mlx4_en_get_netdev(struct mlx4_dev *dev, void *ctx, u8 port)
@@ -309,10 +307,7 @@ static void *mlx4_en_add(struct mlx4_dev *dev) 
	}



	/* Build device profile according to supplied module parameters */

	if (mlx4_en_get_profile(mdev)) {

		mlx4_err(mdev, "Bad module parameters, aborting\n");

		goto err_mr;

	}

	mlx4_en_get_profile(mdev);



	/* Configure which ports to start according to module parameters */

	mdev->port_cnt = 0;