Commit f5636854 authored May 26, 2015 by Maninder Singh Committed by Vinod Koul May 25, 2015

dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch



Currently pch pointer is already dereferenced before NULL check
and thus we are getting below warning:
warn: variable dereferenced before check 'pch'

So initialize struct pl330_dmac *pl330 after NULL check
of dma_pl330_chan *pch.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 8f64b276

drivers/dma/pl330.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
		{
		struct dma_pl330_desc *desc;
		struct dma_pl330_chan *pch = to_pchan(chan);
		struct pl330_dmac *pl330 = pch->dmac;
		struct pl330_dmac *pl330;
		int burst;

		if (unlikely(!pch \|\| !len))
		return NULL;

		pl330 = pch->dmac;

		desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
		if (!desc)
		return NULL;