Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4e981cb authored by Nicolas Iooss's avatar Nicolas Iooss Committed by Petr Mladek
Browse files

printk: add __printf attributes to internal functions 

When compiling with -Wsuggest-attribute=format, gcc complains that some
functions in kernel/printk/printk_safe.c transmit their argument to
printf-like functions without having a printf attribute. Silence these
warnings by adding relevant __printf attributes.

Link: http://lkml.kernel.org/r/20170524054950.6722-1-nicolas.iooss_linux@m4x.org


Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarNicolas Iooss <nicolas.iooss_linux@m4x.org>
Reviewed-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
parent 719f6a70

kernel/printk/printk_safe.c

+5 −5
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ static void queue_flush_work(struct printk_safe_seq_buf *s) 
 * happen, printk_safe_log_store() will notice the buffer->len mismatch

 * and repeat the write.

 */

static int printk_safe_log_store(struct printk_safe_seq_buf *s,

static __printf(2, 0) int printk_safe_log_store(struct printk_safe_seq_buf *s,

						const char *fmt, va_list args)

{

	int add;
@@ -299,7 +299,7 @@ void printk_safe_flush_on_panic(void) 
 * one writer running. But the buffer might get flushed from another

 * CPU, so we need to be careful.

 */

static int vprintk_nmi(const char *fmt, va_list args)

static __printf(1, 0) int vprintk_nmi(const char *fmt, va_list args)

{

	struct printk_safe_seq_buf *s = this_cpu_ptr(&nmi_print_seq);
@@ -330,7 +330,7 @@ void printk_nmi_exit(void) 


#else



static int vprintk_nmi(const char *fmt, va_list args)

static __printf(1, 0) int vprintk_nmi(const char *fmt, va_list args)

{

	return 0;

}
@@ -342,7 +342,7 @@ static int vprintk_nmi(const char *fmt, va_list args) 
 * into itself. It uses a per-CPU buffer to store the message, just like

 * NMI.

 */

static int vprintk_safe(const char *fmt, va_list args)

static __printf(1, 0) int vprintk_safe(const char *fmt, va_list args)

{

	struct printk_safe_seq_buf *s = this_cpu_ptr(&safe_print_seq);