Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4c79818 authored by Axel Lin's avatar Axel Lin Committed by Jiri Kosina
Browse files

HID: prodikeys: make needlessly global symbols static 



The following symbols are not referenced outside this file so
there's no need for it to be in the global name space.

  pcmidi_sustained_note_release
  init_sustain_timers
  stop_sustain_timers
  pcmidi_handle_report
  pcmidi_setup_extra_keys
  pcmidi_snd_initialise
  pcmidi_snd_terminate

Make them static.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 2dcd9543

drivers/hid/hid-prodikeys.c

+8 −7
Original line number Original line Diff line number Diff line
@@ -242,7 +242,7 @@ static void pcmidi_send_note(struct pcmidi_snd *pm, 
	return;

	return;

}

}





void pcmidi_sustained_note_release(unsigned long data)

static void pcmidi_sustained_note_release(unsigned long data)

{

{

	struct pcmidi_sustain *pms = (struct pcmidi_sustain *)data;

	struct pcmidi_sustain *pms = (struct pcmidi_sustain *)data;
@@ -250,7 +250,7 @@ void pcmidi_sustained_note_release(unsigned long data) 
	pms->in_use = 0;

	pms->in_use = 0;

}

}





void init_sustain_timers(struct pcmidi_snd *pm)

static void init_sustain_timers(struct pcmidi_snd *pm)

{

{

	struct pcmidi_sustain *pms;

	struct pcmidi_sustain *pms;

	unsigned i;

	unsigned i;
@@ -264,7 +264,7 @@ void init_sustain_timers(struct pcmidi_snd *pm) 
	}

	}

}

}





void stop_sustain_timers(struct pcmidi_snd *pm)

static void stop_sustain_timers(struct pcmidi_snd *pm)

{

{

	struct pcmidi_sustain *pms;

	struct pcmidi_sustain *pms;

	unsigned i;

	unsigned i;
@@ -499,7 +499,7 @@ static int pcmidi_handle_report4(struct pcmidi_snd *pm, u8 *data) 
	return 1;

	return 1;

}

}





int pcmidi_handle_report(

static int pcmidi_handle_report(

	struct pcmidi_snd *pm, unsigned report_id, u8 *data, int size)

	struct pcmidi_snd *pm, unsigned report_id, u8 *data, int size)

{

{

	int ret = 0;

	int ret = 0;
@@ -518,7 +518,8 @@ int pcmidi_handle_report( 
	return ret;

	return ret;

}

}





void pcmidi_setup_extra_keys(struct pcmidi_snd *pm, struct input_dev *input)

static void pcmidi_setup_extra_keys(

	struct pcmidi_snd *pm, struct input_dev *input)

{

{

	/* reassigned functionality for N/A keys

	/* reassigned functionality for N/A keys

		MY PICTURES =>	KEY_WORDPROCESSOR

		MY PICTURES =>	KEY_WORDPROCESSOR
@@ -602,7 +603,7 @@ static struct snd_rawmidi_ops pcmidi_in_ops = { 
	.trigger = pcmidi_in_trigger

	.trigger = pcmidi_in_trigger

};

};





int pcmidi_snd_initialise(struct pcmidi_snd *pm)

static int pcmidi_snd_initialise(struct pcmidi_snd *pm)

{

{

	static int dev;

	static int dev;

	struct snd_card *card;

	struct snd_card *card;
@@ -720,7 +721,7 @@ int pcmidi_snd_initialise(struct pcmidi_snd *pm) 
	return err;

	return err;

}

}





int pcmidi_snd_terminate(struct pcmidi_snd *pm)

static int pcmidi_snd_terminate(struct pcmidi_snd *pm)

{

{

	if (pm->card) {

	if (pm->card) {

		stop_sustain_timers(pm);

		stop_sustain_timers(pm);